Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth support #153

Open
Abbe98 opened this issue Mar 4, 2018 · 4 comments
Open

OAuth support #153

Abbe98 opened this issue Mar 4, 2018 · 4 comments

Comments

@Abbe98
Copy link

Abbe98 commented Mar 4, 2018

OAuth support would be very valuable, especially for users with Two Factor Authentication enabled.

@MER-C
Copy link
Owner

MER-C commented Mar 5, 2018

I agree and this is something that would be useful for my tools, but this is currently not on my radar. I need to kill off all the non-API using methods first.

@MER-C
Copy link
Owner

MER-C commented Apr 27, 2018

The last method using base was rewritten in 18aaaf9. The next blockers are swapping apiUrl and query for ConcurrentHashMaps (soon) and JSON support (JEP 198).

Instructions: https://www.mediawiki.org/wiki/OAuth/Owner-only_consumers (the more complicated flow can be left later).

The OAuth signature needs to be computed at the last possible moment, immediately before connection.connect() in makeHTTPrequest. OAuth is a MediaWiki extension, so it doesn't belong in Wiki.java. That makes the solution ugly. I'd recommend using bot passwords for now.

@MER-C
Copy link
Owner

MER-C commented May 26, 2018

All HTTP GET parameters are now in the same format as of 56a923f .

@Nirvanchik
Copy link

OAuth is a MediaWiki extension, so it doesn't belong in Wiki.java. That makes the solution ugly.

That's sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Abbe98 @MER-C @Nirvanchik and others