Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: rot only works if there is a $vp slot #32

Open
MHenderson opened this issue Mar 18, 2024 · 2 comments
Open

BUG: rot only works if there is a $vp slot #32

MHenderson opened this issue Mar 18, 2024 · 2 comments

Comments

@MHenderson
Copy link
Owner

The current behaviour is to not rotate if $vp is NULL. But even that seems wrong. We shuold create the viewport and then rotate. Also testing for $vp being NULL assumes that $vp is defined, doesn't it?
@MHenderson
Copy link
Owner Author

I think the answer is just to create the slot if it doesn't exist.

@MHenderson
Copy link
Owner Author

Write a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MHenderson