New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or explain commented-out code in Dockerfile #41

Open

martin-martin opened this issue Jun 7, 2020 · 0 comments

martin-martin commented Jun 7, 2020

There are unused imports in the example Dockerfile in week02/labs/README.md:

# FROM nvidia/cuda
# FROM nvidia/cuda:8.0-cudnn6-devel
# FROM nvidia/cuda:8.0-cudnn5-devel
--snip--
#  CMD jupyter notebook --no-browser --ip=0.0.0.0 --NotebookApp.token= --allow-root

These are unexplained and seem to be unused and can be confusing for students.

I suggest to remove the commented-out lines, or explain their raison d'être.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment