Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add computation of smoothness for graph signals #71

Open
hugofluhr opened this issue Aug 17, 2023 · 2 comments · May be fixed by #72
Open

add computation of smoothness for graph signals #71

hugofluhr opened this issue Aug 17, 2023 · 2 comments · May be fixed by #72
Assignees
Labels
Enhancement New feature or request

Comments

@hugofluhr
Copy link
Collaborator

I want to add a function the computes the smoothness of a signal using the graph laplacian.

Detailed Description

compute the smoothness of any signal defined at each node of the graph using the graph laplacian.

Context / Motivation

Smoothness is one of the basic metrics of GSP and is a good starting point to add other GSP operations to nigsp and start contributing to the package.

Possible Implementation

Straightforward matrix multiplication to get the quadratic form.

@hugofluhr hugofluhr added the Enhancement New feature or request label Aug 17, 2023
@hugofluhr
Copy link
Collaborator Author

hugofluhr commented Aug 18, 2023

I'm not sure how to add the smoothness computation to objects.py as it is assumed there that operations are applied to timeseries and not static signals. Any input on how you want to handle this is welcome.

@smoia
Copy link
Collaborator

smoia commented Aug 18, 2023

I would add a function with mtx, signal as inputs (so no SCGraph) in either timeseries or metrics.

You can also add it then as an object method in this way (until we find a better way to do it):

def nodestrength(self, mean=False): # pragma: no cover

And yes, we'll start renaming timeseries as signals! ;)

@hugofluhr hugofluhr linked a pull request Aug 18, 2023 that will close this issue
18 tasks
@hugofluhr hugofluhr added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Aug 21, 2023
@smoia smoia removed the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants