fix: Correct isBlacklisted() return logic in OTX module

fix: Correct inverted return values in isBlacklisted() function

The isBlacklisted() function had inverted logic - it returned False when
a value was found in the blacklist and True when not found. This caused
all non-blacklisted results to be filtered out throughout the module.

Fixed by correcting the return values:
- Returns True when value is found in blacklist (was False)
- Returns False when value is not in blacklist (was True)

This fixes enrichment failures in:
- IP passive DNS lookups (getIP function)
- Hash malware domain lookups (getHash function)
- Domain enrichment (getDomain function)

Tested with IP address passive DNS enrichment and confirmed hostnames
are now returned correctly from the OTX API.

Author: Dysnome

misp_modules/modules/expansion/otx.py

@@ -68,9 +68,9 @@ def isBlacklisted(value):
 
     for b in blacklist:
         if value in b:
-            return False
+            return True
 
-    return True
+    return False
 
 
 def valid_ip(ip):