Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper utilities for commonly used patterns across transforms #197

Open
ehanson8 opened this issue Jun 27, 2024 · 0 comments
Open

Comments

@ehanson8
Copy link
Contributor

Per @ghukill 's comment:

Using this as an example, but I'm finding these easy to scan now. I do wonder if it's because I've seen quite a few now: list comprehension + filtering clause + or for some values. It's complex, but I think once you take the time to understand one, you kind of understand the rest in the transform.

When we get into orchestration, and all FMR is done, it might be worth looking at some of these and see if some helper utilities can be constructed.

Examples:
https://github.com/MITLibraries/transmogrifier/blob/00d2024d1ef7874d390f46c548fedc0c5de241f9/transmogrifier/sources/xml/dspace_dim.py#L311C9-L317C18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant