Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox->Grid (Dialog--Lines tab) is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) #77

Open
scharlton2 opened this issue Feb 1, 2023 · 3 comments

Comments

@scharlton2
Copy link
Collaborator

MFC version

image

Note that if you press the down button of the layer input (Lines tab) while the subgrid is activated it gets in a bad state -> displays -1 and can't be changed.

Qt version

image

Note that all the activate checkboxes are enabled on the Qt version

Also note that if the down button is pressed on the layer input it asserts (This occurs after the subgrid has been activated/deactivated).

It seems that the Qt dialog needs quite a bit of work for DISV grids

@scharlton2
Copy link
Collaborator Author

Call Stack

gridDialog->applySubgrid
doc->applySubgrid
manager->SetScalarSubgridExtent
m_ExtractCellsForSubgrid->SetCellList
manager->ScalarSubgridOn

doc->subgridOff

Does bounding box change as subgrid changes?

DIS6 yes
DISV
DISU

Do the grid lines change as the subgrid changes?
DIS6 yes -- if it gets smaller
DISV
DISU

Does the origin move when the subgrid changes?
DIS6 yes
DISV
DISU

Can the grid lines extend beyond the bounding box?
DIS6 yes
DISV
DISU

Are model features subsetted?

Is the overlay subsetted?

When does (m_GridDisplayMode == MV_GRID_INTERPOLATE)

@langevin-usgs
Copy link

Hey @scharlton2, I'm not sure this is relevant, but Paul Hsieh implemented two types of representations for cell tops and bottoms. He had a shortcut key that allowed you to toggle between the representations. In one representation, the top elevation for each cell is shown as flat. In the other representation, cell tops and bottoms are interpolated to cell vertices. I think he then divided the cell top/bottom surface into triangles, which were then rendered. Just thought I'd mention it.

@scharlton2
Copy link
Collaborator Author

Thanks @langevin-usgs, I wasn't aware of that. Do you know if he did that for all grids or just for DISV?

@scharlton2 scharlton2 changed the title Toolbox->Grid is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) Toolbox->Grid (Dialog) is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) Feb 4, 2023
@scharlton2 scharlton2 changed the title Toolbox->Grid (Dialog) is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) Toolbox->Grid (Dialog--Lines tab) is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants