Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-commit hook(s) #2274

Open
afuetterer opened this issue Jan 26, 2025 · 1 comment
Open

Set up pre-commit hook(s) #2274

afuetterer opened this issue Jan 26, 2025 · 1 comment

Comments

@afuetterer
Copy link
Contributor

Feature request

This is not a feature request for BERTopic itself, but for the build and CI setup.

I would like to propose to add a .pre-commit-config.yaml and use ruff via the pre-commit hook.

We did this for KeyBERT already last year, see:

What do you think?

Motivation

Right now the CI installs BERTopic itself including its several large dependencies just to lint to code base. This leads to a lint job, that runs ~2-3 minutes instead of a few seconds.

Your contribution

I would like to add a PR, if you like.

@MaartenGr
Copy link
Owner

Yes, that would be great! It feels strange doing it manually when I normally have hooks everywhere else 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants