Fix issue where NonEuclid could pick a path for a connecting user that

puts them into a wall.

Author: Macil

Diff for: src/main/java/tech/macil/minecraft/noneuclid/Intersection.java

@@ -115,17 +115,24 @@ boolean isLocationClose(Location loc) {
                 center.distanceSquared(loc) < maxDistanceSquared;
     }
 
-    public boolean isInIntersection(Location loc) {
-        return Math.abs(loc.getX() - center.getX()) <= (double) width / 2 + 1 &&
-                Math.abs(loc.getZ() - center.getZ()) <= (double) width / 2 + 1;
+    public boolean isInIntersection(Location loc, boolean includeWalls) {
+        double maxDistance = (double) width / 2;
+        if (includeWalls) {
+            maxDistance += 1;
+        }
+        return Math.abs(loc.getX() - center.getX()) <= maxDistance &&
+                Math.abs(loc.getZ() - center.getZ()) <= maxDistance;
     }
 
     public Path getPathForLocation(Location loc, Path previousPath) {
         if (!isLocationClose(loc)) {
             return null;
         }
         assert loc.getWorld() == center.getWorld();
-        if (isInIntersection(loc)) {
+        // If we don't have a previous path, then don't consider the walls as
+        // part of the intersection, so that way players connecting will never
+        // be started inside of a wall.
+        if (isInIntersection(loc, previousPath != null)) {
             return previousPath == null ? getDefaultPath() : previousPath;
         }
         boolean a1 = loc.getZ() > loc.getX() + center.getZ() - center.getX();

Diff for: src/main/java/tech/macil/minecraft/noneuclid/NonEuclidPlugin.java

@@ -215,7 +215,7 @@ private void renderForPlayer(Player player, boolean forceRender) {
                 disablePacketRewriting = false;
             }
 
-            boolean newInIntersection = newPath != null && intersection.isInIntersection(playerLoc);
+            boolean newInIntersection = newPath != null && intersection.isInIntersection(playerLoc, true);
             boolean exitedIntersection = playersInIntersection.contains(player) && (
                     oldPath != newPath || !newInIntersection
             );