Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Members Formatting Broke Name (Japanese) Ordering Field Display #144

Open
LatidoReMe opened this issue Sep 4, 2018 · 1 comment
Open
Labels
bug good first issue Easy to implement and a good way to introduce users to the MagiCircles framework. low priority

Comments

@LatidoReMe
Copy link
Contributor

When you filter by name you'll see both the translated and jp names as shown here:
image
but when you order by Name (Japanese), you don't see the comparative field at all
image
Without looking at the code, this was likely because the special code for name was moved out of itemview and into all views.

To fix this, I suggest we either:

  • Move the special code to itemview only, making the listview display for japanese_name appear as normal
  • Remove Name (Japanese), and just have the ordering field by name
  • Or both of the above
@db0company
Copy link
Member

I'm in favor of first option.

@db0company db0company added this to Backlog in Features & Bugs via automation Oct 9, 2018
@db0company db0company moved this from Backlog to To do (db0 validated, confirmed ready to start) in Features & Bugs Oct 9, 2018
@LatidoReMe LatidoReMe added the good first issue Easy to implement and a good way to introduce users to the MagiCircles framework. label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Easy to implement and a good way to introduce users to the MagiCircles framework. low priority
Projects
Features & Bugs
  
To do (db0 validated, confirmed ready...
Development

No branches or pull requests

2 participants