Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event/Gacha Custom View Glitch #146

Open
LatidoReMe opened this issue Sep 6, 2018 · 2 comments
Open

Event/Gacha Custom View Glitch #146

LatidoReMe opened this issue Sep 6, 2018 · 2 comments
Labels
bug high priority javascript The solution requires work with js, which is done in the MagiCircles/BanGDream-Static repo

Comments

@LatidoReMe
Copy link
Contributor

LatidoReMe commented Sep 6, 2018

When viewing the full page of an event/gacha, there are suppose to be those triangles to help indicate that you can open/close information for each version. However, a pop-up of an event/gacha when on another event/gacha's full page will be missing the triangles
image
Also, there seems to be a duplication glitch happening too. When you exit out of the pop-up on the page, the triangles will be generated again alongside the original triangles, allowing stuff like this to occur:
image
Note: This is an extreme example where I went in and out 4 times. It only generates one extra one at a time

Since users mainly use the pop-up view it ain't the highest of priorities, but it still should be fixed.

@LatidoReMe
Copy link
Contributor Author

Extra Note on this: It still happens even with the new look.
image
It also seems to be shrinking both the event banner AND the gacha banner on the event page, which is interesting since the gacha doesn't have any need to be shrunk
image

@db0company
Copy link
Member

db0company commented Oct 3, 2018

I figured out why it's happening. It's because it's the same function that's called when you load a gacha and an event, so when you open a gacha popup from an event (or event popup from gacha), it's called again. If you keep opening/closing the popup it will keep adding more.

I'm not sure how to fix yet, but at least I know where to look for.

@LatidoReMe The reason why it's resizing the images below them is because it's a table. The lines between the rows and columns of the table are invisible but they're still there. So when more text gets added to the "Japanese version" column, it's reducing the column on the right and all the rows get affected and become smaller as well.

Edit: I added lines to show you what happens:

screen shot 2018-10-03 at 12 29 28 pm

screen shot 2018-10-03 at 12 29 40 pm

@db0company db0company added this to Backlog in Features & Bugs via automation Oct 9, 2018
@db0company db0company added high priority javascript The solution requires work with js, which is done in the MagiCircles/BanGDream-Static repo and removed priority-tbd labels Oct 9, 2018
@db0company db0company moved this from Backlog to To do (db0 validated, confirmed ready to start) in Features & Bugs Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority javascript The solution requires work with js, which is done in the MagiCircles/BanGDream-Static repo
Projects
Features & Bugs
  
To do (db0 validated, confirmed ready...
Development

No branches or pull requests

2 participants