Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: plotting GeometryBasics.MultiPoint no longer works #4728

Open
3 tasks done
asinghvi17 opened this issue Jan 16, 2025 · 0 comments
Open
3 tasks done

Regression: plotting GeometryBasics.MultiPoint no longer works #4728

asinghvi17 opened this issue Jan 16, 2025 · 0 comments
Labels
bug GeometryBasics regression This issue describes a regression from a previous version or commit.

Comments

@asinghvi17
Copy link
Member

  • what version of Makie are you running? (]st -m Makie) 0.22.0
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie) yes
  • What platform + GPU are you on? irrelevant

In v0.21, and with GeometryBasics v0.4.x, MultiPoints were subtypes as AbstractVectors of Points, so plot recipes just worked. Now they aren't, so plotting fails.

Should we add recipes for multipoints to Makie? It's a pretty common thing in GIS to want to plot these kinds of things, and the way we implemented plot recipes for Makie means that geometries are converted directly to GeometryBasics geoms.

MWE:

using Makie, GeometryBasics
scatter(GeometryBasics.MultiPoint(rand(Point2f, 10))

(yields conversion error - no recipe defined)

@asinghvi17 asinghvi17 added bug regression This issue describes a regression from a previous version or commit. GeometryBasics labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GeometryBasics regression This issue describes a regression from a previous version or commit.
Projects
None yet
Development

No branches or pull requests

1 participant