Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not inspectable by default #4736

Open
aplavin opened this issue Jan 18, 2025 · 5 comments · May be fixed by #4739
Open

not inspectable by default #4736

aplavin opened this issue Jan 18, 2025 · 5 comments · May be fixed by #4739
Labels
DataInspector enhancement Feature requests and enhancements good first issue This should come with some instructions! planning For discussion and planning development

Comments

@aplavin
Copy link
Contributor

aplavin commented Jan 18, 2025

Feature description

I find it common for a figure to have lots of images/plots/other objects, but only 1-2 of them are "primary" and should be inspectable. Currently, it requires carefully going through all the plots and specifying inspectable=false almost everywhere.
Can I set it as the default for a figure? Didn't find such an option anywhere, would be convenient!

@aplavin aplavin added the enhancement Feature requests and enhancements label Jan 18, 2025
@ffreyer ffreyer added planning For discussion and planning development DataInspector labels Jan 18, 2025
@ffreyer
Copy link
Collaborator

ffreyer commented Jan 18, 2025

No, you currently can't set a default. But I think that sounds like a good idea. I believe we'd just need to add a default in the default theme https://github.com/MakieOrg/Makie.jl/blob/master/src/theming.jl and @inherit inspectable true here:

inspectable = true

@ffreyer ffreyer added the good first issue This should come with some instructions! label Jan 18, 2025
@aplavin aplavin linked a pull request Jan 18, 2025 that will close this issue
3 tasks
@aplavin
Copy link
Contributor Author

aplavin commented Jan 18, 2025

Thanks for the pointer! Made a PR.

@jkrumbiegel
Copy link
Member

Maybe also a scene based preset? Then all blocks could set it to false on their blockscenes

@ffreyer
Copy link
Collaborator

ffreyer commented Jan 18, 2025

Does that require anything else? I thought it would draw defaults from scene first and then the global defaults, or that scene has a copy of the global defaults?

@jkrumbiegel
Copy link
Member

Hm I guess not, I thought at first something like scene.visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataInspector enhancement Feature requests and enhancements good first issue This should come with some instructions! planning For discussion and planning development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants