Skip to content

[WIP] [EXPERIMENT] Don't send kind, apiVersion in create POST #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cben wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] [EXPERIMENT] Don't send kind, apiVersion in create POST #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d54e4f7
[WIP] [EXPERIMENT] don't set kind, apiVersion
cben May 31, 2018
38c576f
Merge branch 'master' into dont-set-apiversion
cben Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/kubeclient/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,15 +368,11 @@ def delete_entity(resource_name, name, namespace = nil, delete_options: {})
def create_entity(entity_type, resource_name, entity_config)
# Duplicate the entity_config to a hash so that when we assign
# kind and apiVersion, this does not mutate original entity_config obj.
# TODO: skip?
hash = entity_config.to_hash

ns_prefix = build_namespace_prefix(hash[:metadata][:namespace])

# TODO: temporary solution to add "kind" and apiVersion to request
# until this issue is solved
# https://github.com/GoogleCloudPlatform/kubernetes/issues/6439
hash[:kind] = entity_type
hash[:apiVersion] = @api_group + @api_version
response = handle_exception do
rest_client[ns_prefix + resource_name]
.post(hash.to_json, { 'Content-Type' => 'application/json' }.merge(@headers))
Expand Down