Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picture id to service catalog #1262

Open
GilbertCherrie opened this issue Jun 21, 2024 · 3 comments
Open

Add picture id to service catalog #1262

GilbertCherrie opened this issue Jun 21, 2024 · 3 comments
Assignees

Comments

@GilbertCherrie
Copy link
Member

In Manage-IQ ui-service there is an issue where the logo of an order is not using the custom logo that users upload for catalog items.

UI-Service Logo:
Screenshot 2024-06-21 at 10 03 29 AM

Custom Logo set in UI-Classic
Screenshot 2024-06-21 at 10 04 06 AM

In order to use the custom logo in the service ui we need the api to return the image id associated with this service template / service order. The summary page in the UI-service is calling /api/service_orders/id, ideally this api call returns the image id associated with the order / template so that we can render the appropriate image in the service ui.

@Fryguy
Copy link
Member

Fryguy commented Jun 21, 2024

As we discussed in PM, the service catalog items have the picture id, so you can get it indirectly by fetching the service catalog item. That being said, I could see it being useful if the service itself and/or the order itself had the value directly, particularly if the user doesn't have RBAC permissions to the catalog entries.

@Fryguy Fryguy added enhancement and removed bug labels Jun 21, 2024
@Fryguy
Copy link
Member

Fryguy commented Jun 21, 2024

Not sure if we should de-normalize it, or make it a virtual_attribute. I was originally thinking denormalize it (in case the catalog item goes away), but then I think it could get orphaned.

@miq-bot
Copy link
Member

miq-bot commented Sep 30, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants