Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix workflows list with repository #8907

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Aug 31, 2023

Before

After
Screenshot 2023-08-31 at 10 13 29 AM

Fixes #8900

Dependent PR - ManageIQ/ui-components#481

To Test in local -
ui-components 1.5.1 is available with the changes

-or-

Link your local ui-components in classic package.json with the local path instead of version
run yarn build in ui-components
run yarn in ui-classic

@agrare
Copy link
Member

agrare commented Aug 31, 2023

@jeffibm is that actually all that is needed? I pulled this down locally and am not seeing any changes in the form

@agrare
Copy link
Member

agrare commented Aug 31, 2023

Oh I just noticed there is a ui-components PR as well linked in the issue, @jeffibm can you link that in this PR description so it is more obvious that there is a dependency here

@Fryguy
Copy link
Member

Fryguy commented Sep 20, 2023

@jeffibm I have published https://www.npmjs.com/package/@manageiq/ui-components/v/1.5.1 with the changes needed for this PR. Please bump the dependency version and try with that.

@jeffibm jeffibm force-pushed the add-repository-to-workflows branch from 69d69e7 to ab720af Compare September 23, 2023 04:10
@jeffibm
Copy link
Member Author

jeffibm commented Sep 23, 2023

@jeffibm I have published https://www.npmjs.com/package/@manageiq/ui-components/v/1.5.1 with the changes needed for this PR. Please bump the dependency version and try with that.

https://www.npmjs.com/package/@manageiq/ui-components/v/1.5.1

Hey @Fryguy, Bumped up the ui-components version to "1.5.1",` in classic, and was able to see the workflow names.
I have updated the new version in this PR.
image

@jeffibm jeffibm force-pushed the add-repository-to-workflows branch from 7f1841a to 1122aa2 Compare September 23, 2023 05:11
@miq-bot
Copy link
Member

miq-bot commented Sep 23, 2023

Checked commit jeffbonson@1122aa2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit 5bf6aaa into ManageIQ:master Sep 23, 2023
15 checks passed
@Fryguy
Copy link
Member

Fryguy commented Sep 27, 2023

Backported to quinteros in commit 176acef.

commit 176acef7a3f6f6730c2922b161ea36d076384278
Author: Adam Grare <[email protected]>
Date:   Sat Sep 23 09:41:04 2023 -0400

    Merge pull request #8907 from jeffibm/add-repository-to-workflows
    
    Prefix workflows list with repository
    
    (cherry picked from commit 5bf6aaa90d94c1e3416141764b874422d137e3d1)

Fryguy pushed a commit that referenced this pull request Sep 27, 2023
Prefix workflows list with repository

(cherry picked from commit 5bf6aaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix workflows list with repository
4 participants