-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix workflows list with repository #8907
Prefix workflows list with repository #8907
Conversation
@jeffibm is that actually all that is needed? I pulled this down locally and am not seeing any changes in the form |
Oh I just noticed there is a ui-components PR as well linked in the issue, @jeffibm can you link that in this PR description so it is more obvious that there is a dependency here |
@jeffibm I have published https://www.npmjs.com/package/@manageiq/ui-components/v/1.5.1 with the changes needed for this PR. Please bump the dependency version and try with that. |
69d69e7
to
ab720af
Compare
Hey @Fryguy, Bumped up the ui-components version to "1.5.1",` in classic, and was able to see the workflow names. |
7f1841a
to
1122aa2
Compare
Checked commit jeffbonson@1122aa2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Backported to
|
Prefix workflows list with repository (cherry picked from commit 5bf6aaa)
Before
After
Fixes #8900
Dependent PR - ManageIQ/ui-components#481
To Test in local -
ui-components 1.5.1 is available with the changes
-or-
Link your local ui-components in classic package.json with the local path instead of version
run
yarn build
in ui-componentsrun
yarn
in ui-classic