Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev Work] Rework LoadedComicInfo class #144

Open
1 of 4 tasks
ThePromidius opened this issue Feb 12, 2023 · 1 comment
Open
1 of 4 tasks

[Dev Work] Rework LoadedComicInfo class #144

ThePromidius opened this issue Feb 12, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ThePromidius
Copy link
Member

ThePromidius commented Feb 12, 2023

The focus of this story is to extract logic from LoadedComicInfo class.
With all the cover attributes, the class has become polluted.

Some possible ideas:

  • Move logic outside using command design pattern (Would require a complete rework)
  • Divide the class into subclases processing, metadata and cover. (procesign implements metadata and cover processing/functionality due to it being the one that actually saves to files)

While at it it'd be required to add more unit tests since it's the core of MangaManager.

To sum up, a todo list:

  • Design a new structure that's clearer and easier to read
  • Easy accesible for plugins
  • Unit tests
  • Small PRs at a time
@ThePromidius
Copy link
Member Author

#159 tackles this a bit
more specific a48b661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Implemented. Missing Tests
Development

No branches or pull requests

2 participants