Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after generated, the folder name with chinese characters become garbled #170

Open
tmrsm opened this issue Apr 4, 2023 · 6 comments
Open

Comments

@tmrsm
Copy link

tmrsm commented Apr 4, 2023

If a compressed file handled by mangamanager contains a folder name with Chinese characters(BIG5 or GBK),
the folder name will become garbled after generated the comicinfo.

---2023/4/5 edited---
After conducting some tests, it was found that manga manager decompresses using encoding 437, but compresses using the local computer's encoding (in my example, it is BIG5:950), which results in the errors mentioned above.

@majora2007
Copy link
Contributor

Can you provide the folder name characters you're using so I can try and reproduce?

@tmrsm
Copy link
Author

tmrsm commented Apr 12, 2023

folder name characters is 測試

My steps for reproduction are:
1 Create a folder named 測試.
2 Compress it using 7z into 測試.zip (code page: 950).
3 rename zip to cbz
4 Use MM to generate an XML file with the volume set to 1 and no other parameters set.
5 Open the compressed file, and the folder name changes to ┤·╕╒ instead of 測試.

@ivensfor
Copy link

I have also encountered this issue, looking forward to a fix. Thanks.

@ThePromidius
Copy link
Member

Can't reproduce

@ThePromidius
Copy link
Member

2e06778 added some code to use original compression type when writing. Might want to try to reproduce since then.

@tmrsm
Copy link
Author

tmrsm commented Jul 23, 2023

Thank you for your reminder, but the same issue still persists in v1.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants