Fix Issue #198 #210
Closed
Fix Issue #198 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majora2007
reviewed
May 15, 2024
| logger.debug(f"[{'Processing':13s}] Successfully deleted old file and named tempfile as the old file", | ||
| extra=self._logging_extra) | ||
| # If move_on_update setting is True, we should move the temp file to new location, then delete original file. | ||
| if Settings().get("Main", "move_on_update") == True: |
There was a problem hiding this comment.
Can you help me understand this new code and why it would be used?
There was a problem hiding this comment.
Sorry! I thought the pull was matched to commit not pulling HEAD. Was adding file management functionality on my fork to aid in library management. Lemme close this out and make sure any file management code is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
In original code there are a few issues, preventing the Series Title Language setting from operating as expected.
There was also another issue, where after modifying settings in the UI:
save_settings() is called and updates the instance's settings
get_cinfo() is a class method and cannot read the updated saved settings. So settings update in the UI on the AniList provider but do not take effect until restart.
Solution for this was to change the get_cinfo() method to be instance based. Other class methods do not reference the settings values, and can remain class methods.