Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the app settings switches selection mode to subtract #108

Open
thoellt opened this issue Dec 6, 2023 · 2 comments
Open

Opening the app settings switches selection mode to subtract #108

thoellt opened this issue Dec 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@thoellt
Copy link
Contributor

thoellt commented Dec 6, 2023

Possible the button state for the selection mode is overwritten by some global state? As shown in the video, starting with selection using replace, then I open the settings (using the keyboard shortcut) and immediately close it. Now the selection mode is subtract.

Given the suspicious 3 button layout for the theme and its selection of the first item (same as the selection mode) I changed the theme to the last and repeated but the behavior is the same as described above, so there does not seem to be a connection.

selection.mp4
@thoellt thoellt added the bug Something isn't working label Dec 6, 2023
@ThomasKroes
Copy link
Contributor

My first intuition would be that somehow the shortcuts collide. I will take a look asap!

@thoellt
Copy link
Contributor Author

thoellt commented Dec 6, 2023

good point, the shortcut for settings on macOS is cmd + ,

Generally I would suggest that plugins would not use such high level shortcuts (single-modifier, single key) I realize shortcuts rely on plugin focus, so I guess this is fine, as long as we do not use shortcuts with common fixed notations like ctrl/cmd+s etc.
cmd + , on the Mac would be one of those though, as it is a rather universal standard that basically all apps use to open settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants