Fix proxy points selection updates #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasKroes
changed the title
This was
linked to
issues
Feb 28, 2024
ThomasKroes
force-pushed
the
feature/fix_proxy_points_selection
branch
from
9653fe0
to
3a75b02
Compare
Fix typo Remove redundant debug print statement
|
This breaks the linked selection of HSNE scales. I don't think doing getSourceDataset() makes any sense. The linked data is added to this particular dataset, so therefore it should be resolved from there. |
ThomasKroes
added a commit
that referenced
this pull request
Mar 14, 2024
Reverts change made in PR #524 that breaks linked selections between HSNE scales.
JulianThijssen
pushed a commit
that referenced
this pull request
Mar 23, 2024
* Resolve linked data of source datasets (fixes #520) Make sure non-proxy datasets are loaded prior to proxy datasets (fixes #525) * Hide proxy dataset task when loading/importing a project * Fix select all: use Points::setSelectionIndices(...), fixes #521 * Fix select invert: use Points::setSelectionIndices(...), fixes #523 * Fix select none: use Points::setSelectionIndices(...), fixes #522 Fix typo Remove redundant debug print statement * Revert some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points::setSelectionIndices(...)nowPoints::setSelectionIndices(...)nowPoints::setSelectionIndices(...)nowNote: Selection fixes are not complete yet, for some reason selection notifications are not being broadcasted on distant datasets. This will solved in a separate PR.
Closes ManiVaultStudio/t-SNE-Analysis/issues/104