Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure rubocop to enforce coding style on the project #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

configure rubocop to enforce coding style on the project #55

wants to merge 1 commit into from

Conversation

avsej
Copy link

@avsej avsej commented Sep 29, 2022

The patch is huge, but it only configures rubocop rules, and applies them. Also it includes corresponding workflow for Github Actions.

Not all style issues has been fixed. See .rubocop-todo.yml

fixes #54

@avsej
Copy link
Author

avsej commented Sep 29, 2022

@simkim, @giallon, could you take a look? I cannot assign reviewers here.

@avsej avsej mentioned this pull request Sep 29, 2022
Merged
@DamienVoreiter
Copy link

Hello, it might be easier to merge these type of PR if we enable rules one by one ? WDYT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite codebase with 2 space indentation (instead of 4)
2 participants
@avsej @DamienVoreiter