Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send emails to bots #8

Open
MarcKaufmann opened this issue Jan 29, 2021 · 0 comments
Open

Don't send emails to bots #8

MarcKaufmann opened this issue Jan 29, 2021 · 0 comments
Assignees
Labels
async enhancement New feature or request

Comments

@MarcKaufmann
Copy link
Owner

We should ensure we send no emails to bots. Either we pass in an extra parameter to the send-email function/do an extra check before every send email. Alternatively, we could change the mail-adapter-send-email-with-template to check in the database whether the email belongs to a bot, in which case it isn't sent. The benefit of the latter approach is that it doesn't require micromanaging every email-send action, so that forgetting to check for bots doesn't lead to email attempts by mistake. @Bogdanp, what do you think?

@MarcKaufmann MarcKaufmann self-assigned this Jan 29, 2021
@MarcKaufmann MarcKaufmann added the enhancement New feature or request label Feb 4, 2021
@MarcKaufmann MarcKaufmann assigned Bogdanp and unassigned MarcKaufmann Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants