Validate accountId in get_calendar_events, with auto-resolution from calendarId

[Copilot]

get_calendar_events silently accepted a missing accountId and fell through to a "query all accounts" path, producing confusing empty or ambiguous results rather than a clear error. accountId is now validated on every call. When accountId is omitted but calendarId is provided, the tool attempts to auto-resolve the account by searching all enabled accounts' calendars for a unique match.

Changes

• GetCalendarEventsTool

  • When both accountId and calendarId are omitted: returns { "error": "accountId is required" }, consistent with the pattern already used in GetCalendarEventDetailsTool
  • When accountId is omitted but calendarId is provided: searches all enabled accounts in parallel for a calendar with that ID
    • Exactly one match → account is auto-resolved and the call proceeds normally
    • No match → { "error": "No calendar found with id '...'. Provide accountId to specify which account to query." }
    • Multiple matches → { "error": "calendarId '...' exists in multiple accounts; provide accountId to specify which account to query." }
  • Removed the now-dead "query all accounts" branch (GetEnabledAccounts()) and its conditional error message
  • Updated tool and parameter descriptions to reflect the new behavior

• GetCalendarEventsToolTests

  • Added validation tests for null and empty accountId (no calendarId)
  • Added test for single-match auto-resolution via calendarId
  • Added test for no-match error when calendarId is not found in any account
  • Added test for ambiguous error when calendarId exists in multiple accounts

Error responses

{ "error": "accountId is required" }

{ "error": "No calendar found with id '<calendarId>'. Provide accountId to specify which account to query." }

{ "error": "calendarId '<calendarId>' exists in multiple accounts; provide accountId to specify which account to query." }

[rockfordlhotka]

@copilot
Is it possible, if the caller does omit the accountId, to use the calendarId value to find the matching calendar if there are no other matches? In other words, if there's only one calendar with that id, we could just use the id value right?

[Copilot]

@copilot
Is it possible, if the caller does omit the accountId, to use the calendarId value to find the matching calendar if there are no other matches? In other words, if there's only one calendar...

Yes, implemented in commit 1897f0a. When accountId is omitted but calendarId is provided, the tool now searches all enabled accounts' calendars in parallel. If exactly one account owns a calendar with that ID, it's used automatically. If zero match, it returns "No calendar found with id '...'". If more than one match, it returns "calendarId '...' exists in multiple accounts; provide accountId to specify which account to query."