Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance entry.py to allow for an additional package.json #2135

Open
leeuwe opened this issue Jun 24, 2022 · 4 comments
Open

Enhance entry.py to allow for an additional package.json #2135

leeuwe opened this issue Jun 24, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed priority: medium

Comments

@leeuwe
Copy link
Member

leeuwe commented Jun 24, 2022

Is your feature request related to a problem? Please describe.
It would be useful for robot-framework-browser-extensions if rfbrowser init would allow for an additional path to a package.json used by the browser extensions. That would make that the node packages will all live in the same location, which I think is preferable. It would also ease the use of extensions

Describe the solution you'd like
I'd like something like

def _rfbrowser_init(skip_browser_install: bool, file: str):

usage:
rfbrowser init skip_browser_install file="path/to/extensions/package.json"

Describe alternatives you've considered
Alternatives are folks having to manually install and debug the package installation themselves and you're likely to end up with multiple node-modules folders in your project, which I consider undesirable.

@aaltat aaltat added enhancement New feature or request priority: medium labels Jun 24, 2022
@aaltat
Copy link
Member

aaltat commented Jun 24, 2022

@allcontributors please add @leeuwe for ideas

@allcontributors
Copy link
Contributor

@aaltat

I've put up a pull request to add @leeuwe! 🎉

@mkorpela
Copy link
Member

@leeuwe could you explain more about what problems you have now with the package linking?

I was thinking that we might also maybe get some help from https://docs.npmjs.com/cli/v7/using-npm/workspaces

@leeuwe
Copy link
Member Author

leeuwe commented Jun 26, 2022

For example: npm @axe-core/playwright requires obviously playwright, what we already have installed for Browser library.

Npm doesn't handle this very well if it's in a different folder, and I don't like playwright to be installed twice

@Snooz82 Snooz82 added this to the v18.0.0 milestone Sep 17, 2023
@aaltat aaltat modified the milestones: v17.5.2, v18.0.0 Oct 13, 2023
@aaltat aaltat modified the milestones: v18.0.0, v18.1.0 Oct 30, 2023
@Snooz82 Snooz82 added the help wanted Extra attention is needed label Nov 15, 2023
@Snooz82 Snooz82 modified the milestones: v18.0.0, Some Next Issues Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed priority: medium
Projects
None yet
Development

No branches or pull requests

4 participants