Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Files #3301

Open
martamedovova-ext91522 opened this issue Dec 4, 2023 · 12 comments
Open

Upload Files #3301

martamedovova-ext91522 opened this issue Dec 4, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request priority: medium
Milestone

Comments

@martamedovova-ext91522
Copy link

Hello,

how can I upload 2 files in one step with Browser Library?

Can you update KW Update File for Update Files or create new :-)???

@aaltat
Copy link
Member

aaltat commented Dec 4, 2023

You mean Upload File By Selector keyword? In any case, it uses setInputFiles behind the scenes. The Playwright side setInputFiles supports multiple files and your need can be done. Can you do the PR too?

@aaltat aaltat added enhancement New feature or request priority: medium labels Dec 4, 2023
@aaltat
Copy link
Member

aaltat commented Dec 4, 2023

@allcontributors please add @martamedovova-ext91522 for ideas?

Copy link
Contributor

@aaltat

I've put up a pull request to add @martamedovova-ext91522! 🎉

@martamedovova-ext91522
Copy link
Author

Yes, I meant Upload File By Selector, would need Upload Files by Selector :)
Will you create this KW then? :-)

@aaltat
Copy link
Member

aaltat commented Dec 4, 2023

Anyone who has similar interests, can do a pull request and make the necessary changes. It’s not guaranteed that change will be implemented or when that might happen. If you are in a rush, doing that by yourself is the most fastest way.

@Snooz82
Copy link
Member

Snooz82 commented Dec 7, 2023

I would not want to do a new keyword actually.
I would just allow the file path to be a list or a dictionary or list of dictionary.

This is basically same as Playwright allows it.

files: string|Array<string>|Object|Array<Object>
    name: string
    mimeType: string
    buffer: Buffer

I think we can probably not do Buffer, but lets analyse first.
So if we do not support Buffer, we do not need dictionaries.
But that could be relevant for remote executions.

Or is anyone strongly thinking that a new keyword is a must.

@aaltat
Copy link
Member

aaltat commented Dec 7, 2023

I am not in favor of new keyword, enhancing existing keyword to support multiple files is better way.

@martamedovova-ext91522
Copy link
Author

I do not need the new KW but at least need have this function at the current kw?

@aaltat
Copy link
Member

aaltat commented Dec 7, 2023

No idea about buffer, but if it is complicated, I would skip it. Unless there is strong need for it.

@martamedovova-ext91522
Copy link
Author

I would say I will be needed very soon.

@Snooz82
Copy link
Member

Snooz82 commented Feb 2, 2024

@martamedovova-ext91522
What do you need very soon? @aaltat was talking about the Buffer.
I doubt we can do Buffer.

Do you need directory or multiple files soon?
RoboCon in Helsinki is next week and also RoboCon Online is end of February.
So it might be tricky to find time.

@martamedovova-ext91522
Copy link
Author

Sorry I meant the uploading multiple files on the same time.
Sure, I am aware about the RoboCon.
I just say it would be helpfull feature :)

@Snooz82 Snooz82 self-assigned this Oct 6, 2024
@Snooz82 Snooz82 modified the milestones: v18.9.0, v18.10.0 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants