Improve regex for chrome version #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiya and thanks for the PR. Idea looks useful - Ill have a look of the changes over the weekend. |
|
Perfect thanks! I just fixed up the logic a little for handling the "latest" and I made it so it will always grab the last entry in the entry list, which is helpful for using the new logic I'm introducing for grabbing version by something like |
|
@rasjani we make quite a lot of use of webdrivermanager.py at robocorp/rpaframework. Would be interested in getting this merged. What are the current parts blocking this PR from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
There was a small issue with downloading specific chromedrivers as the versions have gotten extra long and extravagant. For example to download chromedriver version 80, you would have to type out
webdrivermanager chrome:83.0.4103.14... man that is brutal!I went ahead and improved the regex for the
namekey from the API request to account for just getting a specific version by doing something likechrome:83orchrome:80to keep things simple, and of course you can go deeper in the version number, as i just just add.0to the version number to make sure it doesn't pick up a random minor version when doing the regex. ( most major version number releases will have something like 81.0 or 83.0 )... so this should suffice.With this you can just write
webdriveragent chrome:83now and it will download chromdriver version 83.cheers