Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys not working for Thumbs Up/Down in YT Music #3901

Closed
CydeSwype opened this issue Oct 15, 2020 · 7 comments
Closed

Hotkeys not working for Thumbs Up/Down in YT Music #3901

CydeSwype opened this issue Oct 15, 2020 · 7 comments

Comments

@CydeSwype
Copy link

CydeSwype commented Oct 15, 2020

Hotkeys don't trigger Thumbs Up/Down in YT Music

OS: macOS 10.15.7 (19H2)
Application Version: 4.7.1 (4.7.1)

A summary of the issue. If suitable, include the steps required to reproduce the bug.

  1. Switch to Youtube Music version of the app.
  2. Assign a hotkey to thumbs up or thumbs down (if not already assigned)
  3. Play music as normal
  4. Use assigned hotkey to initiate thumbs up/down

Expected result: Thumbs up/down is triggered and saved

Actual result: No effect (no highlighted thumb icon, thumbs down doesn't skip track, etc.)

Note that this issue doesn't appear to be present in Google Play Music version of the app, hotkeys work there for thumbs up/down as normal.

Per @jostrander :

There seems to be some kind of disconnect between the hot keys and ytmusic.js, but it ytmusic.js has it implemented, so it should be fine in future builds once that's resolved. A separate issue would be fine.

Originally posted by @jostrander in #3892 (comment)

@welcome
Copy link

welcome bot commented Oct 15, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.

To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

@jostrander
Copy link
Collaborator

Do you happen to also have the 'Unknown Artist' problem in YTM as seen in #3888?

@CydeSwype
Copy link
Author

Ahh, yes I do have that issue! I hadn't even noticed that.

@CydeSwype
Copy link
Author

I'll build from source to see if that resolves the issue.

@jostrander
Copy link
Collaborator

I believe that its resolved with 6.2.2 then, I had accidentally went back to the wrong patch when testing.

@CydeSwype
Copy link
Author

Confirmed! Building from source solved this issue, so your theory on the update for ytmusic.js is correct.

@jostrander
Copy link
Collaborator

I'm going to close this out then, as its already resolved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants