Skip to content

Commit fd5018f

Browse files
authored
Merge pull request #266 from ohader/compat-props
Fix dynamic property deprecation in TraverserTest & TokenizerTest
2 parents e91630a + 8a0ed79 commit fd5018f

5 files changed

Lines changed: 13 additions & 10 deletions

File tree

.github/workflows/benchmark.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
phpbench:
1111
name: "PHPBench"
12-
runs-on: "ubuntu-20.04"
12+
runs-on: "ubuntu-latest"
1313

1414
strategy:
1515
fail-fast: false
@@ -30,7 +30,7 @@ jobs:
3030

3131
- name: "Install dependencies with Composer"
3232
uses: "ramsey/composer-install@v2"
33-
33+
3434
- name: Run performance tests
3535
run: |
3636
php test/benchmark/run.php 10

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
phpunit:
1111
name: "PHPUnit"
12-
runs-on: "ubuntu-20.04"
12+
runs-on: "ubuntu-latest"
1313

1414
strategy:
1515
fail-fast: false

.github/workflows/cs.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
php-cs-fixer:
1111
name: "php-cs-fixer"
12-
runs-on: "ubuntu-20.04"
12+
runs-on: "ubuntu-latest"
1313

1414
strategy:
1515
fail-fast: false
@@ -25,7 +25,7 @@ jobs:
2525
uses: shivammathur/setup-php@v2
2626
with:
2727
php-version: ${{ matrix.php-version }}
28-
28+
2929
- name: cs fix
3030
run: |
3131
wget -q https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.19.3/php-cs-fixer.phar

test/HTML5/Parser/TokenizerTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -970,22 +970,20 @@ public function testText()
970970
// ================================================================
971971
// Utility functions.
972972
// ================================================================
973-
protected function createTokenizer($string, $debug = false)
973+
protected function createTokenizer($string)
974974
{
975975
$eventHandler = new EventStack();
976976
$scanner = new Scanner($string);
977977

978-
$scanner->debug = $debug;
979-
980978
return array(
981979
new Tokenizer($scanner, $eventHandler),
982980
$eventHandler,
983981
);
984982
}
985983

986-
public function parse($string, $debug = false)
984+
public function parse($string)
987985
{
988-
list($tok, $events) = $this->createTokenizer($string, $debug);
986+
list($tok, $events) = $this->createTokenizer($string);
989987
$tok->parse();
990988

991989
return $events;

test/HTML5/Serializer/TraverserTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77

88
class TraverserTest extends \Masterminds\HTML5\Tests\TestCase
99
{
10+
/**
11+
* @var \Masterminds\HTML5
12+
*/
13+
protected $html5;
14+
1015
protected $markup = '<!doctype html>
1116
<html lang="en">
1217
<head>

0 commit comments

Comments
 (0)