Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snackbar should allow placing the action button on its own line. #1423

Closed
Keboo opened this issue Sep 23, 2019 · 6 comments · Fixed by #1755
Closed

Snackbar should allow placing the action button on its own line. #1423

Keboo opened this issue Sep 23, 2019 · 6 comments · Fixed by #1755
Labels
enhancement good first issue Items are good for new contributors. Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/
Milestone

Comments

@Keboo
Copy link
Member

Keboo commented Sep 23, 2019

From the specification

If an action is long, it can be displayed on a third line.

Example

To do this we should do the following (this assumes #1422 has already been completed):
[ ] - Add a new enum dependency property to the Snackbar control. The enum should have the values Inline, SeparateLine, and Auto. The default of the property should be Auto.
[ ] - When the property is set to Inline the action button should display to the right of the message (as it works now).
[ ] - When the property is set to SeparateLine the action button should be moved below the message and right aligned.
[ ] - When the property is set to Auto we should put in a trigger that only moves the action button onto its own line when there are two or more lines of text. We can detect this case by simply watching the height of the Content.
[ ] - Ensure that an example of each is present in the demo application.

@Keboo Keboo added enhancement Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ good first issue Items are good for new contributors. labels Sep 23, 2019
@rgomez90
Copy link
Contributor

Actually working on #1422.

Can take a look at this when finished.

@christyjacob4
Copy link

Hey @Keboo can I start working on this?

@Keboo
Copy link
Member Author

Keboo commented Oct 3, 2019

@rgomez90 are you still planning on working on this one?

@rgomez90
Copy link
Contributor

rgomez90 commented Oct 3, 2019

Yes! I was waiting for you to review #1432, since resolving #1422 before, is needed for this

But I didn't started, so if @christyjacob4 wants, can take it. I'll take another one then, no problems.

@Keboo
Copy link
Member Author

Keboo commented Oct 3, 2019

@christyjacob4 thanks, I think @rgomez90 has this one already

@christyjacob4
Copy link

Okay sure @Keboo thanks

greuelpirat added a commit to greuelpirat/MaterialDesignInXamlToolkit that referenced this issue Apr 21, 2020
@Keboo Keboo added this to the 3.1.1 milestone Apr 23, 2020
Keboo added a commit that referenced this issue Apr 24, 2020
…utton (#1755)

* Added Snackbar.ActionButtonPlacement to support own line for action button (#1423)

* Fixed typo

Co-Authored-By: Kevin B <[email protected]>

* Moved SnackbarActionButtonPlacementModeConverter to Converters (#1755)

* SnackbarActionButtonPlacementModeConverter.ConvertBack throws InvalidOperationException (#1755)

* Move Trigger for DockPanel.Dock into ControlTemplate (#1755)

* Added SnackbarMessage.InlineActionButtonMaxHeight

* Added SnackbarMessage.ContentMaxHeight, moved usage from ContentPresenter to DockPanel

Co-authored-by: Kevin B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Items are good for new contributors. Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/
Projects
None yet
3 participants