-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snackbar should allow placing the action button on its own line. #1423
Comments
Actually working on #1422. Can take a look at this when finished. |
Hey @Keboo can I start working on this? |
@rgomez90 are you still planning on working on this one? |
Yes! I was waiting for you to review #1432, since resolving #1422 before, is needed for this But I didn't started, so if @christyjacob4 wants, can take it. I'll take another one then, no problems. |
@christyjacob4 thanks, I think @rgomez90 has this one already |
Okay sure @Keboo thanks |
…utton (#1755) * Added Snackbar.ActionButtonPlacement to support own line for action button (#1423) * Fixed typo Co-Authored-By: Kevin B <[email protected]> * Moved SnackbarActionButtonPlacementModeConverter to Converters (#1755) * SnackbarActionButtonPlacementModeConverter.ConvertBack throws InvalidOperationException (#1755) * Move Trigger for DockPanel.Dock into ControlTemplate (#1755) * Added SnackbarMessage.InlineActionButtonMaxHeight * Added SnackbarMessage.ContentMaxHeight, moved usage from ContentPresenter to DockPanel Co-authored-by: Kevin B <[email protected]>
From the specification
Example
To do this we should do the following (this assumes #1422 has already been completed):
[ ] - Add a new enum dependency property to the Snackbar control. The enum should have the values
Inline
,SeparateLine
, andAuto
. The default of the property should beAuto
.[ ] - When the property is set to
Inline
the action button should display to the right of the message (as it works now).[ ] - When the property is set to
SeparateLine
the action button should be moved below the message and right aligned.[ ] - When the property is set to
Auto
we should put in a trigger that only moves the action button onto its own line when there are two or more lines of text. We can detect this case by simply watching the height of the Content.[ ] - Ensure that an example of each is present in the demo application.
The text was updated successfully, but these errors were encountered: