Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ComboBoxes onto their own pages in the demo app #1704

Closed
4 tasks done
Keboo opened this issue Mar 21, 2020 · 0 comments · Fixed by #1749 or #1754
Closed
4 tasks done

Separate ComboBoxes onto their own pages in the demo app #1704

Keboo opened this issue Mar 21, 2020 · 0 comments · Fixed by #1749 or #1754
Labels
demo app Items that relate to the demo application good first issue Items are good for new contributors. up-for-grabs
Milestone
3.1.1

Comments

@Keboo
Copy link
Member

Keboo commented Mar 21, 2020 •
edited
Loading

Right now the "Fields" page is getting quite large. It would be good to separate out the combo boxes onto their own page.

This can be done with the following steps:

  • Create a new UserControl to hold the new ComoBox page
  • Add the new page to the MainWindowViewModel.GenerateDemoItems() method
  • Move the documentation links from the fields page to the combo box page
  • Move all of the ComobBox controls out of the Fields.xaml into the new ComboBox user control.
@Keboo Keboo added up-for-grabs good first issue Items are good for new contributors. demo app Items that relate to the demo application labels Mar 21, 2020
greuelpirat added a commit to greuelpirat/MaterialDesignInXamlToolkit that referenced this issue Apr 19, 2020
@greuelpirat
created ComboBoxes.xaml (MaterialDesignInXAML#1704)
884f12e
greuelpirat added a commit to greuelpirat/MaterialDesignInXamlToolkit that referenced this issue Apr 19, 2020
@greuelpirat
Removed ComboBoxes from Fields.xaml and reordered elements (MaterialD…
aff1776 
…esignInXAML#1704)
greuelpirat added a commit to greuelpirat/MaterialDesignInXamlToolkit that referenced this issue Apr 19, 2020
@greuelpirat
centered DocumentationLink-Icon (MaterialDesignInXAML#1704)
ba829f6
@greuelpirat greuelpirat mentioned this issue Apr 19, 2020
Merged
@Keboo Keboo added this to the 3.1.1 milestone Apr 20, 2020
Keboo pushed a commit that referenced this issue Apr 20, 2020
@greuelpirat
Page for ComboBoxes in demo app (#1749)
6e20c00 
* created ComboBoxes.xaml (#1704)

* Removed ComboBoxes from Fields.xaml and reordered elements (#1704)

* centered DocumentationLink-Icon (#1704)
greuelpirat added a commit to greuelpirat/MaterialDesignInXamlToolkit that referenced this issue Apr 21, 2020
@greuelpirat
Updated README for comboboxes page (MaterialDesignInXAML#1704)
e65607c
@greuelpirat greuelpirat mentioned this issue Apr 21, 2020
Merged
Keboo pushed a commit that referenced this issue Apr 23, 2020
@greuelpirat
Updated README for comboboxes page (#1704) (#1754)
a434693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo app Items that relate to the demo application good first issue Items are good for new contributors. up-for-grabs
Projects
None yet
Milestone
3.1.1
1 participant
@Keboo