Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShowMeTheXAML to version 2.0.0 #2119

Closed
Keboo opened this issue Oct 10, 2020 · 2 comments · Fixed by #2123
Closed

Update ShowMeTheXAML to version 2.0.0 #2119

Keboo opened this issue Oct 10, 2020 · 2 comments · Fixed by #2123
Labels
enhancement Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ up-for-grabs

Comments

@Keboo
Copy link
Member

Keboo commented Oct 10, 2020

ShowMeTheXAML just released a new 2.0.0 with some breaking changes.
The key differences is the Key properties on the XamlDisplay class was renamed to UniqueKey. We should update the version we are using to 2.0.0 and update all of the usages to using the new property.

These dependencies are managed with Paket not NuGet directly so you will need to use paket to update and restore the dependency. Keep in mind there is a separate issue for updating paket (#2118) so the exact command needed will depend on if that work has been done.

@Keboo Keboo added enhancement up-for-grabs Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ labels Oct 10, 2020
@jespersh
Copy link
Contributor

@Keboo what should one expect from this Uno.UI dependency defined in the nuspec file of SMTX?

      <group targetFramework=".NETStandard2.0">
        <dependency id="Uno.UI" version="3.0.17" exclude="Build,Analyzers" />
      </group>

@Keboo
Copy link
Member Author

Keboo commented Oct 16, 2020

The netstandard dependency should not be picked up by WPF since the .NET Framework and NET Core App dependencies should be a better match. I would not expect that to affect this project.

Keboo pushed a commit that referenced this issue Oct 17, 2020
 #2119 (#2123)

* Updated ShowMeTheXAML to version 2.0.0.0 and fixed breaking changes - rename Key xaml property to UniqueKey

* merge fixes

Co-authored-by: menas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ up-for-grabs
Projects
None yet
2 participants