Skip to content

Commit 8769666

Browse files
committed
compute: drop migration-plan labels from temporal-bucketing comments
The comments named the migration plan's nodes, which mean nothing to a reader, and described the union input in terms of a mixed-variant `concat_many` case rather than what the code does.
1 parent 5d0b257 commit 8769666

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

src/compute/src/render.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1378,10 +1378,9 @@ impl<'scope, T: RenderTimestamp + MaybeBucketByTime> Context<'scope, T> {
13781378
.get(&self.config_set)
13791379
.try_into()
13801380
.expect("must fit");
1381-
// Temporal bucketing (node C8) is `Vec`-internal: decode
1382-
// the edge into it, then re-encode the `Vec` result to
1383-
// columnar so this Union input stays columnar and
1384-
// `concat_many` sees no mixed variants.
1381+
// Temporal bucketing operates on `Vec`: decode the edge
1382+
// into it, then re-encode the result so this Union input
1383+
// is a columnar edge like every other.
13851384
let os = os.into_vec();
13861385
CollectionEdge::Columnar(vec_to_columnar(
13871386
T::maybe_apply_temporal_bucketing(

test/sqllogictest/temporal_bucketing.slt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,12 +278,12 @@ Target cluster: quickstart
278278
EOF
279279

280280
# -----------------------------------------------------------------------------
281-
# Runtime tests (node Ta). With `enable_compute_temporal_bucketing` on, the
281+
# Runtime tests. With `enable_compute_temporal_bucketing` on, the
282282
# bucketed dataflow edges are re-encoded to the columnar representation instead
283283
# of re-wrapping `Vec`. These tests turn the flag on and assert the bucketed
284284
# dataflows still produce the correct logical results, and that a consolidating
285285
# `Union` concatenating a bucketed input with a `Direct` input yields the right
286-
# output (the mixed `concat_many` case, now columnar on both legs).
286+
# output, which reaches `concat_many` as a columnar edge like the other leg.
287287
# -----------------------------------------------------------------------------
288288

289289
simple conn=mz_system,user=mz_system
@@ -344,7 +344,7 @@ SELECT * FROM rt_topk
344344

345345
# Mixed Union: `EXCEPT ALL` of a temporal-filtered leg (bucketed) against a
346346
# plain relation (Direct) lowers to a consolidating `Union` with per-input
347-
# strategies `[TemporalBucketing, Direct]`. After node Ta both legs reach
347+
# strategies `[TemporalBucketing, Direct]`. Both legs reach
348348
# `concat_many` as columnar edges.
349349
query T multiline
350350
EXPLAIN PHYSICAL PLAN AS VERBOSE TEXT FOR

0 commit comments

Comments
 (0)