Skip to content

Commit d574472

Browse files
antiguruclaude
andcommitted
doc: record pushing columnar containers into TopK as a TODO
TopK renders its stages over `Vec` containers, so the columnar output edge is produced by a single encode at the end of the plan. Note at that seam that the encode disappears once the stages themselves carry columnar containers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 5a24c98 commit d574472

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎src/compute/src/render/top_k.rs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -669,6 +669,10 @@ where
669669
/// therefore injective and the output carries no within-batch duplicates, so a
670670
/// non-consolidating `ColumnBuilder` matches the prior `map`. The row is pushed
671671
/// borrowed, materializing no owned `Row` per record.
672+
///
673+
/// TODO: TopK renders its stages over `Vec` containers, so this encode sits at
674+
/// the very end of the plan. Pushing columnar containers down through
675+
/// `build_topk` and the monotonic path would remove it.
672676
fn topk_result_to_columnar<'s, T>(
673677
collection: VecCollection<'s, T, (Row, Row), Diff>,
674678
) -> CollectionEdge<'s, T>

0 commit comments

Comments
 (0)