Skip to content

Commit da910b5

Browse files
committed
compute: count fuel-test output through the container
A per-record `inspect` needs `&Container: IntoIterator`, and on macOS resolving that recurses through `objc2`'s blanket impls until the trait solver overflows, so `lint-macos` fails to compile the test. Counting through the container avoids the resolution entirely. The same test reads the container directly from the commit that makes FlatMap's output columnar onward, so this only closes the window where it did not.
1 parent 2ca573d commit da910b5

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

src/compute/src/render/flat_map.rs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ mod tests {
329329
use differential_dataflow::input::Input;
330330
use mz_expr::MapFilterProject;
331331
use mz_repr::{Datum, ReprScalarType};
332-
use timely::dataflow::operators::Inspect;
332+
use timely::dataflow::operators::InspectCore;
333333
use timely::dataflow::operators::capture::{Capture, Extract};
334334

335335
use super::*;
@@ -370,7 +370,15 @@ mod tests {
370370
let scope = stream.scope();
371371
let (oks, _errs) =
372372
flat_map_stage(stream, scope, exprs, func, mfp, Antichain::new(), budget);
373-
oks.inspect(move |_| *sink.borrow_mut() += 1);
373+
// Count through the container rather than per record. A
374+
// per-record `inspect` needs `&Container: IntoIterator`, and
375+
// resolving that on macOS recurses through `objc2`'s blanket
376+
// impls until the trait solver overflows.
377+
oks.inspect_container(move |event| {
378+
if let Ok((_time, data)) = event {
379+
*sink.borrow_mut() += data.len();
380+
}
381+
});
374382
input
375383
});
376384

0 commit comments

Comments
 (0)