Skip to content

Commit db5feaf

Browse files
committed
dyncfg: clarify that Environment is not environmentd
Name the coarsest targeting granularity, not the process. balancerd's configs are Environment because balancerd resolves them against its own regional LaunchDarkly context, with nothing finer beneath it, not because balancerd is lumped in with environmentd. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RZo8dwEyXbXwUq6wb7BkeU
1 parent ee24059 commit db5feaf

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

‎src/dyncfg/src/lib.rs‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,11 @@ use tracing::error;
8787
/// [`Config::get_with_overrides`] or from a per-replica config set. Without
8888
/// that, the override never takes effect and the declaration is a silent
8989
/// no-op.
90-
/// - A config realized in `environmentd` (or `balancerd`) with no single replica
91-
/// in scope is [`Environment`].
90+
/// - A config realized in `environmentd` with no single replica in scope is
91+
/// [`Environment`]. So is every `balancerd` config. `balancerd` syncs
92+
/// LaunchDarkly itself, against a `balancer` context keyed by cloud provider,
93+
/// region and build version, and has no environment, cluster or replica
94+
/// beneath it to target.
9295
/// - A config consumed at plan time, once per cluster, is [`Cluster`].
9396
///
9497
/// NOTE: a config whose value must agree across the replicas of one cluster
@@ -103,6 +106,10 @@ use tracing::error;
103106
pub enum ParameterScope {
104107
/// Environment-wide only; no cluster/replica overrides. The default, so all
105108
/// existing synced parameters are unchanged.
109+
///
110+
/// NOTE: this names the coarsest targeting granularity, not the
111+
/// `environmentd` process. A config a process other than `environmentd`
112+
/// resolves for itself, with nothing finer beneath it, is `Environment`.
106113
Environment,
107114
/// Cluster-coherent: env-wide base plus per-cluster overrides. Evaluated
108115
/// with the `cluster` context (replica-free) and resolved at plan time via

0 commit comments

Comments
 (0)