Skip to content

Commit e9cf871

Browse files
committed
compute: rename pool spill-threads dyncfg to column_paged_batcher_spill_worker_count
The prior name was registered in LaunchDarkly with the wrong data type, and LD does not allow changing a parameter's type after creation; a fresh name lets the flag be recreated correctly. Default and semantics unchanged.
1 parent 053a1d9 commit e9cf871

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/compute-types/src/dyncfgs.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ pub const COLUMN_PAGED_BATCHER_USE_POOL: Config<bool> = Config::new(
138138
/// rates. Thread spawning is once per process: raising the value later has
139139
/// no effect beyond re-enabling, and lowering it to zero falls back to
140140
/// inline eviction while spawned threads idle.
141-
pub const COLUMN_PAGED_BATCHER_POOL_SPILL_THREADS: Config<usize> = Config::new(
142-
"column_paged_batcher_pool_spill_threads",
141+
pub const COLUMN_PAGED_BATCHER_SPILL_WORKER_COUNT: Config<usize> = Config::new(
142+
"column_paged_batcher_spill_worker_count",
143143
2,
144144
"Buffer-pool spill threads for off-worker eviction I/O; 0 evicts inline on the caller.",
145145
);
@@ -566,5 +566,5 @@ pub fn all_dyncfgs(configs: ConfigSet) -> ConfigSet {
566566
.add(&COLUMN_PAGED_BATCHER_LZ4)
567567
.add(&COLUMN_PAGED_BATCHER_SWAP_PAGEOUT)
568568
.add(&COLUMN_PAGED_BATCHER_USE_POOL)
569-
.add(&COLUMN_PAGED_BATCHER_POOL_SPILL_THREADS)
569+
.add(&COLUMN_PAGED_BATCHER_SPILL_WORKER_COUNT)
570570
}

src/compute/src/compute_state.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ impl ComputeState {
328328

329329
let enabled = ENABLE_COLUMN_PAGED_BATCHER_SPILL.get(config);
330330
let use_pool = COLUMN_PAGED_BATCHER_USE_POOL.get(config);
331-
let spill_threads = COLUMN_PAGED_BATCHER_POOL_SPILL_THREADS.get(config);
331+
let spill_threads = COLUMN_PAGED_BATCHER_SPILL_WORKER_COUNT.get(config);
332332
let codec = COLUMN_PAGED_BATCHER_LZ4.get(config).then_some(Codec::Lz4);
333333
let swap_pageout = COLUMN_PAGED_BATCHER_SWAP_PAGEOUT.get(config);
334334

0 commit comments

Comments
 (0)