Skip to content

Commit eedb274

Browse files
def-claude
andcommitted
expr, cargo-fuzz: address review nits
Drop the duplicated value_between doc summary line, and document that the fuzz runner's interrupted classification treats a kernel OOM SIGKILL as interrupted too, relying on libFuzzer's rss limit to catch memory blowups as artifact-producing OOMs first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5GiWioZM6CWrwWgfBADDR
1 parent 948371a commit eedb274

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/expr/src/interpret.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ impl<'a> ResultSpec<'a> {
256256
}
257257
}
258258

259-
/// A spec that matches values between the given (non-null) min and max.
260259
/// A spec for the values between `min` and `max` inclusive.
261260
///
262261
/// Unordered bounds widen to [`ResultSpec::value_all`] instead of collapsing

test/cargo-fuzz/mzcompose.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,10 @@ def _reap(self, job: Job) -> None:
437437
):
438438
# Killed by a signal (Ctrl-C, step timeout, an external kill)
439439
# without a crash artifact: an interrupted run, not a crash.
440-
# Crashes always leave an artifact, so this cannot mask one.
440+
# libFuzzer-detected crashes always leave an artifact, so this
441+
# cannot mask one. A kernel OOM SIGKILL is also reported as
442+
# interrupted; the rss limit passed to libFuzzer catches memory
443+
# blowups as artifact-producing OOMs well before the kernel does.
441444
self.succeeded.append(job)
442445
say(
443446
f"- {job.name} interrupted by signal {-job.returncode} [{secs}s] "

0 commit comments

Comments
 (0)