diff --git a/src/compute/src/compute_state.rs b/src/compute/src/compute_state.rs index 0644868820736..2d439f0125465 100644 --- a/src/compute/src/compute_state.rs +++ b/src/compute/src/compute_state.rs @@ -66,7 +66,7 @@ use timely::progress::frontier::Antichain; use timely::scheduling::Scheduler; use timely::worker::Worker as TimelyWorker; use tokio::sync::{oneshot, watch}; -use tracing::{Level, debug, error, info, span, warn}; +use tracing::{Level, debug, error, info, span, trace, warn}; use uuid::Uuid; use crate::arrangement::manager::{TraceBundle, TraceManager}; @@ -443,7 +443,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> { } fn handle_update_configuration(&mut self, params: ComputeParameters) { - info!("Applying configuration update: {params:?}"); + debug!("Applying configuration update: {params:?}"); let ComputeParameters { workload_class, @@ -876,9 +876,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> { let peek_persist_stash_available = self.compute_state.peek_stash_persist_location.is_some(); if !peek_persist_stash_available && enabled { - tracing::error!( - "missing peek_stash_persist_location but peek stash is enabled" - ); + error!("missing peek_stash_persist_location but peek stash is enabled"); } enabled && peek_persist_stash_available }; @@ -936,7 +934,7 @@ impl<'a, A: Allocate + 'static> ActiveComputeState<'a, A> { .metrics .stashed_peek_seconds .observe(duration.as_secs_f64()); - tracing::trace!(?stashing_peek.peek, ?duration, "finished stashing peek response in persist"); + trace!(?stashing_peek.peek, ?duration, "finished stashing peek response in persist"); Some(response) } else { @@ -1336,7 +1334,7 @@ impl PersistPeek { } let count: usize = d.try_into().map_err(|_| { - tracing::error!( + error!( shard = %metadata.data_shard, diff = d, ?row, "persist peek encountered negative multiplicities", ); @@ -1451,7 +1449,7 @@ impl IndexPeek { }); if copies.is_negative() { let error = cursor.key(&storage); - tracing::error!( + error!( target = %self.peek.target.id(), diff = %copies, %error, "index peek encountered negative multiplicities in error trace", ); diff --git a/src/storage/src/storage_state.rs b/src/storage/src/storage_state.rs index f9698d1e60e66..55c6533f01029 100644 --- a/src/storage/src/storage_state.rs +++ b/src/storage/src/storage_state.rs @@ -111,7 +111,7 @@ use timely::progress::frontier::Antichain; use timely::worker::Worker as TimelyWorker; use tokio::sync::{mpsc, watch}; use tokio::time::Instant; -use tracing::{info, warn}; +use tracing::{debug, info, warn}; use uuid::Uuid; use crate::internal_control::{ @@ -737,7 +737,7 @@ impl<'w, A: Allocate> Worker<'w, A> { // management being a bit of a mess. we should clean this up and remove weird if // statements like this. if resume_uppers.values().all(|frontier| frontier.is_empty()) || as_of.is_empty() { - tracing::info!( + info!( ?resume_uppers, ?as_of, "worker {}/{} skipping building ingestion dataflow \ @@ -985,7 +985,7 @@ impl<'w, A: Allocate> Worker<'w, A> { } for ingestion_id in to_remove { - tracing::info!(?ingestion_id, "removing oneshot ingestion"); + info!(?ingestion_id, "removing oneshot ingestion"); self.storage_state.oneshot_ingestions.remove(&ingestion_id); } } @@ -1302,7 +1302,7 @@ impl StorageState { } StorageCommand::UpdateConfiguration(params) => { // These can be done from all workers safely. - tracing::info!("Applying configuration update: {params:?}"); + debug!("Applying configuration update: {params:?}"); // We serialize the dyncfg updates in StorageParameters, but configure // persist separately. @@ -1452,6 +1452,6 @@ impl StorageState { /// Drop the identified oneshot ingestion from the storage state. fn drop_oneshot_ingestion(&mut self, ingestion_id: uuid::Uuid) { let prev = self.oneshot_ingestions.remove(&ingestion_id); - tracing::info!(%ingestion_id, existed = %prev.is_some(), "dropping oneshot ingestion"); + info!(%ingestion_id, existed = %prev.is_some(), "dropping oneshot ingestion"); } }