diff --git a/src/persist-client/src/iter.rs b/src/persist-client/src/iter.rs index 050062e4ec68a..6a0c4b5fb7078 100644 --- a/src/persist-client/src/iter.rs +++ b/src/persist-client/src/iter.rs @@ -34,7 +34,6 @@ use mz_persist_types::arrow::{ArrayBound, ArrayIdx, ArrayOrd}; use mz_persist_types::columnar::data_type; use mz_persist_types::part::Part; use mz_persist_types::{Codec, Codec64}; -use semver::Version; use timely::progress::Timestamp; use tracing::{Instrument, debug_span}; @@ -45,11 +44,6 @@ use crate::internal::metrics::{ReadMetrics, ShardMetrics}; use crate::internal::state::{HollowRun, RunMeta, RunOrder, RunPart}; use crate::metrics::Metrics; -/// Versions prior to this had bugs in consolidation, or used a different sort. However, -/// we can assume that consolidated parts at this version or higher were consolidated -/// according to the current definition. -pub const MINIMUM_CONSOLIDATED_VERSION: Version = Version::new(0, 67, 0); - /// The data needed to fetch a batch part, bundled up to make it easy /// to send between threads. #[derive(Debug, Clone)] diff --git a/src/storage-types/src/sources.rs b/src/storage-types/src/sources.rs index 0fcdda02d8783..201578b1e2fd8 100644 --- a/src/storage-types/src/sources.rs +++ b/src/storage-types/src/sources.rs @@ -2180,9 +2180,10 @@ mod tests { // and the two versions would not consolidate out. // This can impact correctness! // - // If you need to change how SourceDatas are encoded, that's still fine... - // but we'll also need to increase - // the MINIMUM_CONSOLIDATED_VERSION as part of the same release. + // If you need to change how SourceDatas are encoded, that can be + // okay, but think through the consequences: a record whose old and + // new encodings differ never consolidates away inside existing + // persist shards. Loop in the persist team. assert_eq!( encoded, reencoded.as_str(),