Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider droping support for Oreo (api 26+) and having Pie as minimum (api 28+) #17

Open
MateusRodCosta opened this issue Oct 3, 2023 · 0 comments
Assignees
Labels
Android Related to Android
Milestone

Comments

@MateusRodCosta
Copy link
Owner

MateusRodCosta commented Oct 3, 2023

Background info

  • Originally Vidya Music was a Android Marshmallow app (api 23+)
  • Later on, on version 1.0.0 the Minimum Android version was bumped to Nougat ( api 24+) due to the Android N using OpenJDK and that being considered a more stable environment
  • Later on on 1.2.0 the minimum version was update to Oreo (api 26+) on the basis that Android Oreo is what we could call "Modern Android"

Rationale

  • The target demographic of Vidya Music are gamers (and some non-gamers) who like to listen to video game music (VGM)
  • Gamers are likely to be more tech-savvy than the average user and are somewhat less likely to be running old Android version (this might be different on emerging countries)
  • From looking at the stats on the Play Store I believe I at no point have ever seen users running the app on Android 8.x

Current Play Store stats

As of October 1st, 2023 Vidya Music had 57 users:

Version Amount Percent
Total 57 100%
Android 13 35 61.4%
Android 12 9 15.79%
Android 11 5 8.77%
Android 9 3 5.26%
Android 14 3 5.26%
Android 10 1 1.75%
Android 12L 1 1.75%

Benefits and drawbacks

  • Moving from dex version 038 (Added in Android O) to dex version 039 (added in Android P)
    • benefits so far unknown, could lead to performance improvements
  • When minSdk is set to 28, dex files are uncompressed in the APK (source)
    • this means slightly larger APK but shouldn't affect download sizes due to AAB compression and Play Store delivery
  • Shaving support for 8.x (Android O) devices
    • it seems no users on that version are interested in the app
  • This still doesn't allow us to remove the explicit check for SystemUiMode.edgeToEdge as that feature requires at least Android 10 (api 29)
    • as a benefit this only makes one version I would need to test under the emulator: Android 9

When?

I don't think I would do this change for 1.3.0, so for now it's planned for 2.0.0.

@MateusRodCosta MateusRodCosta added the Android Related to Android label Oct 3, 2023
@MateusRodCosta MateusRodCosta added this to the 2.0.0 milestone Oct 3, 2023
@MateusRodCosta MateusRodCosta self-assigned this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Related to Android
Projects
None yet
Development

No branches or pull requests

1 participant