Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default_symbol from the VectorTileStyle #131

Open
Maximkaaa opened this issue Feb 6, 2025 · 0 comments
Open

Remove default_symbol from the VectorTileStyle #131

Maximkaaa opened this issue Feb 6, 2025 · 0 comments
Labels
A-vector-tiles good first issue Good for newcomers T-enhancement Improve an existing feature
Milestone

Comments

@Maximkaaa
Copy link
Owner

The default symbol structure is very strange, as it is a collection of symbols of different types. It is especially wrong when it comes to point symbol and label symbol, because both of them are used to render point geometries.

But as it turns out we don't need this structure at all. It can be replaced by the style rules with no filters, which is much more flexible. We can also introduce logic in the vector tile processor to apply a styling rule to a feature only if the symbol type and layer geometry type are aligned. This will allow us to have three different style rules with no filters, each of which will apply to the corresponding geometry type.

Doing this requires to:

  • remove the field from the style structure
  • remove the logic in the vt_processor that uses default symbols
  • change the styles used in the examples to reflect the change
@Maximkaaa Maximkaaa added good first issue Good for newcomers T-enhancement Improve an existing feature A-vector-tiles labels Feb 6, 2025
@Maximkaaa Maximkaaa added this to the 0.2 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vector-tiles good first issue Good for newcomers T-enhancement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant