Revert "fix(router): fall back when serializing protocol-relative URLs"

This reverts commit 41d6a8b.

Author: atscott

goldens/public-api/router/errors.api.md

@@ -37,8 +37,6 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     OUTLET_NOT_ACTIVATED = 4012,
     // (undocumented)
-    PROTOCOL_RELATIVE_URL_NOT_ALLOWED = 4019,
-    // (undocumented)
     ROOT_SEGMENT_MATRIX_PARAMS = 4003,
     // (undocumented)
     TWO_SEGMENTS_WITH_SAME_OUTLET = 4006,

packages/router/src/errors.ts

@@ -29,5 +29,4 @@ export const enum RuntimeErrorCode {
   INFINITE_REDIRECT = 4016,
   INVALID_ROUTER_LINK_INPUTS = 4017,
   ERROR_PARSING_URL = 4018,
-  PROTOCOL_RELATIVE_URL_NOT_ALLOWED = 4019,
 }

packages/router/src/url_tree.ts

@@ -6,13 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {
-  computed,
-  ɵformatRuntimeError as formatRuntimeError,
-  ɵRuntimeError as RuntimeError,
-  Service,
-  Signal,
-} from '@angular/core';
+import {computed, ɵRuntimeError as RuntimeError, Service, Signal} from '@angular/core';
 
 import {RuntimeErrorCode} from './errors';
 import type {Router} from './router';
@@ -479,17 +473,6 @@ export class DefaultUrlSerializer implements UrlSerializer {
   /** Converts a `UrlTree` into a url */
   serialize(tree: UrlTree): string {
     const segment = `/${serializeSegment(tree.root, true)}`;
-    if (segment.startsWith('//')) {
-      if (typeof ngDevMode === 'undefined' || ngDevMode) {
-        console.warn(
-          formatRuntimeError(
-            RuntimeErrorCode.PROTOCOL_RELATIVE_URL_NOT_ALLOWED,
-            `Cannot serialize a UrlTree that would produce a protocol-relative URL. Falling back to '/' instead.`,
-          ),
-        );
-      }
-      return '/';
-    }
     const query = serializeQueryParams(tree.queryParams);
     const fragment =
       typeof tree.fragment === `string` ? `#${encodeUriFragment(tree.fragment)}` : '';

packages/router/test/create_url_tree.spec.ts

@@ -22,15 +22,6 @@ import {timeout} from '@angular/private/testing';
 
 describe('createUrlTree', () => {
   const serializer = new DefaultUrlSerializer();
-  const protocolRelativeUrlWarning = `NG04019: Cannot serialize a UrlTree that would produce a protocol-relative URL. Falling back to '/' instead.`;
-
-  function expectProtocolRelativeUrlFallback(tree: UrlTree): void {
-    const warn = spyOn(console, 'warn');
-
-    expect(serializer.serialize(tree)).toEqual('/');
-    expect(warn).toHaveBeenCalledOnceWith(protocolRelativeUrlWarning);
-  }
-
   let router: Router;
   beforeEach(() => {
     router = TestBed.inject(Router);
@@ -143,62 +134,6 @@ describe('createUrlTree', () => {
     expect(serializer.serialize(t)).toEqual('/%2Fone/two%2Fthree');
   });
 
-  describe('leading empty path commands', () => {
-    it('should fall back for absolute navigations that would serialize as protocol-relative', () => {
-      const t = router.createUrlTree(['/', '', '', 'attacker.example', 'collect']);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should fall back for an unsafe primary outlet string', async () => {
-      await router.navigateByUrl('/safe');
-      const t = router.createUrlTree([{outlets: {primary: '/attacker.example/collect'}}]);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should fall back for an unsafe primary outlet array', () => {
-      const t = router.createUrlTree([{outlets: {primary: ['', 'attacker.example', 'collect']}}]);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should fall back for unsafe parent-relative commands', async () => {
-      router.resetConfig([{path: 'source', component: class {}}]);
-      await router.navigateByUrl('/source');
-      const t = create(router.routerState.root.firstChild!, [
-        '../',
-        '',
-        'attacker.example',
-        'collect',
-      ]);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should fall back for an escaped slash after an empty path command', () => {
-      const t = router.createUrlTree(['/', '', {segmentPath: '/'}]);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should fall back for final empty path commands', () => {
-      const t = router.createUrlTree(['/', '', '']);
-
-      expectProtocolRelativeUrlFallback(t);
-    });
-
-    it('should not normalize a leading empty path command in a secondary outlet', () => {
-      const t = router.createUrlTree(['/', {outlets: {right: ['', 'child']}}]);
-
-      expect(t.root.children['right'].segments.map((segment) => segment.path)).toEqual([
-        '',
-        'child',
-      ]);
-      expect(serializer.serialize(t)).toEqual('/(right:/child)');
-    });
-  });
-
   describe('named outlets', () => {
     it('should preserve secondary segments', async () => {
       const p = serializer.parse('/a/11/b(right:c)');

packages/router/test/router_link_spec.ts

@@ -329,27 +329,4 @@ describe('RouterLink', () => {
     await harness.navigateByUrl('/different');
     expect(anchor.getAttribute('href')).toBe('/different/child');
   });
-
-  it('falls back to the root for a link that would generate a protocol-relative href', async () => {
-    @Component({
-      template: `<a [routerLink]="commands" queryParamsHandling="preserve">commands</a>`,
-      imports: [RouterLink],
-    })
-    class WithLink {
-      readonly commands = ['/', '', 'attacker.example', 'collect'];
-    }
-
-    TestBed.configureTestingModule({
-      providers: [provideRouter([{path: '', component: WithLink}])],
-    });
-    const warn = spyOn(console, 'warn');
-    const fixture = TestBed.createComponent(WithLink);
-
-    await fixture.whenStable();
-
-    expect(fixture.nativeElement.querySelector('a').getAttribute('href')).toBe('/');
-    expect(warn).toHaveBeenCalledWith(
-      `NG04019: Cannot serialize a UrlTree that would produce a protocol-relative URL. Falling back to '/' instead.`,
-    );
-  });
 });

packages/router/test/url_serializer.spec.ts

@@ -13,13 +13,11 @@ import {
   encodeUriQuery,
   encodeUriSegment,
   serializePath,
-  UrlSegment,
   UrlSegmentGroup,
 } from '../src/url_tree';
 
 describe('url serializer', () => {
   const url = new DefaultUrlSerializer();
-  const protocolRelativeUrlWarning = `NG04019: Cannot serialize a UrlTree that would produce a protocol-relative URL. Falling back to '/' instead.`;
 
   it('should parse the root url', () => {
     const tree = url.parse('/');
@@ -449,39 +447,6 @@ describe('url serializer', () => {
     });
   });
 
-  describe('leading empty path segments', () => {
-    it('should fall back for a parsed primary outlet that would serialize as protocol-relative', () => {
-      const warn = spyOn(console, 'warn');
-      const tree = url.parse('/(primary://attacker.example/collect)?token=RESET_TOKEN');
-
-      expect(url.serialize(tree)).toBe('/');
-      expect(warn).toHaveBeenCalledOnceWith(protocolRelativeUrlWarning);
-    });
-
-    it('should fall back for multiple leading empty primary segments', () => {
-      const warn = spyOn(console, 'warn');
-      const tree = url.parse('/attacker.example/collect');
-      tree.root.children[PRIMARY_OUTLET].segments.unshift(
-        new UrlSegment('', {}),
-        new UrlSegment('', {}),
-      );
-
-      expect(url.serialize(tree)).toBe('/');
-      expect(warn).toHaveBeenCalledOnceWith(protocolRelativeUrlWarning);
-    });
-
-    it('should fall back for unsafe trees with secondary outlets, query params, and fragments', () => {
-      const warn = spyOn(console, 'warn');
-      const tree = url.parse(
-        '/attacker.example/collect(popup:compose)?token=RESET_TOKEN#OAUTH_TOKEN',
-      );
-      tree.root.children[PRIMARY_OUTLET].segments.unshift(new UrlSegment('', {}));
-
-      expect(url.serialize(tree)).toBe('/');
-      expect(warn).toHaveBeenCalledOnceWith(protocolRelativeUrlWarning);
-    });
-  });
-
   describe('error handling', () => {
     it('should throw when invalid characters inside children', () => {
       expect(() => url.parse('/one/(left#one)')).toThrowError();