Skip to content

Commit 3eaae88

Browse files
AleksanderBodurriatscott
authored andcommitted
fix(devtools): recurse correctly when finding hydration error nodes
findErrorNodesForHydrationOverlay recursed into findNodesForHydrationOverlay, which stops descending at the first node with any hydration status. Mismatched nodes nested under a hydrated or skipped node were therefore never found and never highlighted on the page. Recurse into the error-node finder itself so nested mismatches are highlighted.
1 parent 48cbdd1 commit 3eaae88

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎devtools/projects/ng-devtools-backend/src/lib/hydration/hydration-overlays.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ function findErrorNodesForHydrationOverlay(
138138
return {node: node.nativeElement!, status: node.hydration};
139139
}
140140
if (node.children.length) {
141-
return findNodesForHydrationOverlay(node.children);
141+
return findErrorNodesForHydrationOverlay(node.children);
142142
}
143143
return [];
144144
});

0 commit comments

Comments
 (0)