fix(migrations): avoid migrating queries multiple times in signal queries migration

When a source file was part of multiple tsconfigs (e.g. a library's build,
prod and spec configs), the signal queries migration rewrote its queries once
per compilation unit, producing duplicated fields and imports. This happened
because source queries were collected from all program files instead of only
the files owned by the current unit.

Only migrate queries whose file belongs to the current compilation unit, while
still registering all queries for reference resolution.

Tested by adding a schematic spec with overlapping build and test tsconfigs.

Fixes angular#71147

Author: MeAkib

packages/core/schematics/migrations/signal-queries-migration/migration.ts

@@ -420,14 +420,18 @@ export class SignalQueriesMigration extends TsurgeComplexMigration<
     const knownQueries = new KnownQueries(info, this.config, globalMetadata);
     const referenceResult: ReferenceResult<ClassFieldDescriptor> = {references: []};
     const sourceQueries: ExtractedQuery[] = [];
+    const unitSourceFiles = new Set(sourceFiles);
 
     // Detect all queries in this unit.
     const queryWholeProgramVisitor = (node: ts.Node) => {
       // Detect all SOURCE queries and migrate them, if possible.
       const extractedQuery = extractSourceQueryDefinition(node, reflector, evaluator, info);
       if (extractedQuery !== null) {
         knownQueries.registerQueryField(extractedQuery.node, extractedQuery.id);
-        sourceQueries.push(extractedQuery);
+        // Files shared between tsconfigs are only migrated by the unit that owns them.
+        if (unitSourceFiles.has(extractedQuery.node.getSourceFile())) {
+          sourceQueries.push(extractedQuery);
+        }
         return;
       }
 

packages/core/schematics/test/queries_migration_spec.ts

@@ -71,6 +71,41 @@ describe('signal queries migration', () => {
     expect(content).toContain("readonly ref = contentChild.required<ElementRef>('ref');");
   });
 
+  it('should migrate a query once when its file is part of multiple tsconfigs', async () => {
+    writeFile('/tsconfig.spec.json', '{}');
+    writeFile(
+      '/angular.json',
+      JSON.stringify({
+        version: 1,
+        projects: {
+          t: {
+            root: '',
+            architect: {
+              build: {options: {tsConfig: './tsconfig.json'}},
+              test: {options: {tsConfig: './tsconfig.spec.json'}},
+            },
+          },
+        },
+      }),
+    );
+    writeFile(
+      '/index.ts',
+      `
+      import {ContentChild, ElementRef, Directive} from '@angular/core';
+
+      @Directive({})
+      export class SomeDirective {
+        @ContentChild('ref') ref!: ElementRef;
+      }`,
+    );
+
+    await runMigration();
+
+    const content = tree.readContent('/index.ts');
+    expect(content.match(/contentChild\.required/g)?.length).toBe(1);
+    expect(content.match(/from '@angular\/core'/g)?.length).toBe(1);
+  });
+
   it('should report correct statistics', async () => {
     writeFile(`node_modules/@tsconfig/strictest/tsconfig.json`, `{}`);
     writeFile(