Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(late bytes): add optional param of session_id so we can be explicit #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jayceslesar
Copy link
Contributor

maybe close #86 🤷

Comment on lines 539 to 548
steam_id: str,
late_bytes: bytes,
current_time: datetime,
session_id: str | None = None,
) -> str | None:
"""Add late bytes to the database and blob storage.

No-ops and returns an error message if late bytes are found or there are no active sessions.
"""
with engine.connect() as conn:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function getting super ugly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collisions in updated_at when POSTing late_bytes
1 participant