chore: remove protocol set#8519
Merged
Merged
Conversation
LTCatt
added
处理中
Contributor
Author
|
顺带提一嘴，可以考虑一下 bump 到 .NET Framework 4.8 了，因为 4.6.2 的支持是 2027 年 1 月 1 日结束 |
Collaborator
大图
|
Member
|
.NET Framework 4.6.2 下， |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
移除了对 SecurityProtocol 的设定，让 Schannel 的行为更贴近自动选择
原因
PCL 使用的所有 API 均不支持 TLS v1.2- 的协议版本，而且几乎没有哪家 CDN(Amazon、Cloudflare、Microsoft Azure、Tencent、Aliyun) 不支持 TLS v1.2+，所以使用 SecurityProtocol 进行向下兼容并没有任何意义，反而主动禁用了更安全的 TLS v1.3 协议
参考资料
https://myssl.com/piston-meta.mojang.com?domain=piston-meta.mojang.com&port=443&status=success
https://myssl.com/api.minecraftservices.com?domain=api.minecraftservices.com&status=success
https://www.ssllabs.com/ssltest/analyze.html?d=bmclapi2.bangbang93.com
https://learn.microsoft.com/en-us/windows/win32/secauthn/protocols-in-tls-ssl--schannel-ssp-
https://learn.microsoft.com/zh-cn/dotnet/fundamentals/code-analysis/quality-rules/ca5386