Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack rate limits #76

Open
emmanueltouzery opened this issue May 10, 2019 · 3 comments
Open

slack rate limits #76

emmanueltouzery opened this issue May 10, 2019 · 3 comments

Comments

@emmanueltouzery
Copy link
Contributor

emmanueltouzery commented May 10, 2019

https://api.slack.com/docs/rate-limits#events_api

I've been hit by slack rate limits (and not even doing that many calls.. they've become much more stringent with that recently). When that happens we get back http 429, which slack-web forwards to the caller, and there is a HTTP header: Retry-After: <number of seconds>.

I think that maybe slack-web should optionally handle that for the user. I can maybe try to make a PR, when I get some time, but we'd need to agree as to how to do implement that.

Do we add a new option to all existing calls RateLimitHandling = RateLimitFail | RateLimitWaitAndResend? Do we do it automatically out of the box, without any way to disable it (in which case there is no API change)? Or do we consider slack-web is the wrong layer in the stack to deal with that, and we change nothing compared to the current situation?

@jpvillaisaza
Copy link
Collaborator

Your pull request would be for option 1, right?

@emmanueltouzery
Copy link
Contributor Author

I wanted your opinion before starting anything (if I'll find time to do it at all). So all options are on the table.

@jpvillaisaza
Copy link
Collaborator

Yeah, option 1 sounds good. Is that the best for your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants