Skip to content

Confirmation message for Depends-On: #5050

@hansen-matt

Description

@hansen-matt

Expected Behavior

Sometimes the changes for feature/B depend on the changes for feature/A. The Depends-On: #1234 syntax allows me to block merging feature/B until the PR for feature/A merges, but a small typo can make that fail silently.

It would be nice if there was an obvious user-facing confirmation that Depends-On: was parsed successfully. One option would be to post a comment, like the existing "Mergify rebased successfully" comment. Another option would be an emoji on the PR description, like what is done when commenting "@Mergifyio rebase".

Actual Behavior

depends-on: #1234, depends on: #1234, Depends-On #1234 etc don't create a dependency, but look correct at first glance.

Steps to Reproduce the Problem

  1. Create two PRs
  2. Add Depends-On: #1 to PR #2, but get the syntax wrong
  3. Approve PR #2 and watch it merge automatically

Specifications

  • Pull Request URL:
  • Mergify Config URL:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions