Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing "Unique" and "Enforce Unique constraint" error message #3520

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Fixing "Unique" and "Enforce Unique constraint" error message #3520

merged 16 commits into from
Jul 1, 2024

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Jun 24, 2024 •
edited
Loading

'Unique' and 'Enforce Unique Constraint' error message would not work when 'Apply Default Value on Update' option was checked after setting a 'Default Value' in 'Defaults' tab.

1

Fixes #3457

@VitorVieiraZ VitorVieiraZ changed the title Fixing "Unique" and "Enforce Unique constraint" error message WIP- Fixing "Unique" and "Enforce Unique constraint" error message Jun 24, 2024
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9647956985

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 59.897%
Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.07%
Covered Lines: 7671
Relevant Lines: 12807
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9647956985

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 59.897%
Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.07%
Covered Lines: 7671
Relevant Lines: 12807
💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP- Fixing "Unique" and "Enforce Unique constraint" error message Fixing "Unique" and "Enforce Unique constraint" error message Jun 24, 2024
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9648156091

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9648156091

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9648156091

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9665778385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9665778385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9665778385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

tomasMizera
tomasMizera requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

app/qml/form/MMFormPage.qml Outdated Show resolved Hide resolved
app/qml/form/MMFormPage.qml Outdated Show resolved Hide resolved
app/qml/form/MMFormPage.qml Outdated Show resolved Hide resolved
app/qml/form/editors/MMFormCalendarEditor.qml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9680031228

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 59.905%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.06%
Covered Lines: 7672
Relevant Lines: 12807
💛 - Coveralls

tomasMizera
tomasMizera requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting there, there should be only two things left to do.

  1. Fix gallery, please open the gallery - page 'editors'. There are some errors due to these new properties
  2. When shouldShowValidationMsg is false, we should keep the validation state valid. For this we simply need to adjust the condition for the Valid state of the validationStateGroup to consider also the shouldShowValidationMsg flag. ... Maybe shouldShowValidation would be a better name then :)

app/qml/components/private/MMBaseInput.qml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9714183687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 59.959%
Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
Totals Coverage Status
Change from base Build 9583371861: -0.008%
Covered Lines: 7679
Relevant Lines: 12807
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9714896853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.913%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.05%
Covered Lines: 7673
Relevant Lines: 12807
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9714896853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.913%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.05%
Covered Lines: 7673
Relevant Lines: 12807
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9714896853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.913%
Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
Totals Coverage Status
Change from base Build 9583371861: -0.05%
Covered Lines: 7673
Relevant Lines: 12807
💛 - Coveralls

tomasMizera
tomasMizera approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🚀

@tomasMizera tomasMizera merged commit 49e8ecc into master Jul 1, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix/enforceUniqueConstraint branch July 1, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasMizera tomasMizera tomasMizera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Unique" and "Enforce Unique constraint" does not work
4 participants
@VitorVieiraZ @coveralls @tomasMizera @inputapp-bot